hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3833) ability to support includes/excludes list in Hbase
Date Wed, 18 May 2011 18:38:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035565#comment-13035565
] 

stack commented on HBASE-3833:
------------------------------

On timeout and then kill, if Karthik suggested it, then it must be a good idea (smile).

No biggie but FYI and for next time, style is to put spaces around operators; not "(int i=0;i<3;i++)"
but "(int i = 0; i < 3; i++)"

This is bad, no?

{code}
+    try {
+      BufferedWriter out = new BufferedWriter(new FileWriter(exFilePath));
+      out.write(info.getHostnamePort());
+      out.close();
+    } catch (IOException e) {
+    }
{code}

If you fail to write the excludes file, the test will fail anyways?  Just let out the IOE?

Here:

{code}
+    for (int i=0;i<3;i++) {
+    	Thread.sleep(2000);
+    	if (!cluster.getMaster().getServerManager().getOnlineServersList().contains(info));
+    	break;
+    }
{code}

You already have a three minute timeout on the test so this wait of six seconds is probably
not needed... just loop till it happens OR until junit intercedes and kills the thing because
its going on too long.

Again, none of the above are that important... more for the next time.

Just to note that NodeDecommissionedException is very close to the YouAreDeadException.  Even
so, I think it a good idea to add it.

This patch is for TRUNK?  HServerInfo is deprecated.  Do you want to use that?

Nice. You added refreshNodes to the shell.

I'm not clear on how a decommissioned node, once added to the excludes, is cleared of its
regions.  Did I miss it?

Thanks Vishal.




> ability to support includes/excludes list in Hbase
> --------------------------------------------------
>
>                 Key: HBASE-3833
>                 URL: https://issues.apache.org/jira/browse/HBASE-3833
>             Project: HBase
>          Issue Type: Improvement
>          Components: client, regionserver
>    Affects Versions: 0.90.2
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: excl-patch.txt, excl-patch.txt
>
>
> An HBase cluster currently does not have the ability to specify that the master should
accept regionservers only from a specified list. This helps preventing administrative errors
where the same machine could be included in two clusters. It also allows the administrator
to easily remove un-ssh-able machines from the cluster.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message