Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 48200 invoked from network); 14 Apr 2011 04:54:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 Apr 2011 04:54:48 -0000 Received: (qmail 85591 invoked by uid 500); 14 Apr 2011 04:54:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 85556 invoked by uid 500); 14 Apr 2011 04:54:46 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 85539 invoked by uid 99); 14 Apr 2011 04:54:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Apr 2011 04:54:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Apr 2011 04:54:42 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id DEAC6A02FA for ; Thu, 14 Apr 2011 04:54:05 +0000 (UTC) Date: Thu, 14 Apr 2011 04:54:05 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: <479529683.57027.1302756845908.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1563934.111011289344343216.JavaMail.jira@thor> Subject: [jira] [Commented] (HBASE-3210) HBASE-1921 for the new master MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-3210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019693#comment-13019693 ] stack commented on HBASE-3210: ------------------------------ Subbu: Your patch looks great (as does your reenabling of TZK). I'm up for committing it -- was going to run all tests first first though since a pretty significant change -- but your patch is 4x the time it needs to be since the bulk is formatting only changes. Would you mind resubmitting the patch absent the formatting changes. Try also to keep lines < 80. Good stuff Subbu. > HBASE-1921 for the new master > ----------------------------- > > Key: HBASE-3210 > URL: https://issues.apache.org/jira/browse/HBASE-3210 > Project: HBase > Issue Type: Improvement > Reporter: Jean-Daniel Cryans > Priority: Critical > Fix For: 0.92.0 > > Attachments: HBASE-3210-When_the_Master_s_session_times_out_and_there_s_only_one,_cluster_is_wedged.patch > > > HBASE-1921 was lost when writing the new master code. I guess it's going to be much harder to implement now, but I think it's a critical feature to have considering the reasons that brought me do it in the old master. There's already a test in TestZooKeeper which has been disabled a while ago. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira