hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3731) NPE in HTable.getRegionsInfo()
Date Mon, 04 Apr 2011 22:17:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015654#comment-13015654
] 

stack commented on HBASE-3731:
------------------------------

2., unless you think the getHRegionInfoOrNull to awkward to use and that we should get rid
of it and turn all calls to getHREgionInfos into getHRegionInfoOrNulls.

> NPE in HTable.getRegionsInfo()
> ------------------------------
>
>                 Key: HBASE-3731
>                 URL: https://issues.apache.org/jira/browse/HBASE-3731
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Liyin Tang
>
> In HTable.getRegionInfo
> <code>
> HRegionInfo info = Writables.getHRegionInfo(
>             rowResult.getValue(HConstants.CATALOG_FAMILY,
>                 HConstants.REGIONINFO_QUALIFIER));
> </code>
> But the rowResult.getValue() may return null, and Writables.getHRegionInfo will throw
NullPoinException when the parameter is null.
> 2 fixes here: 
> 1) In Writables.getHRegionInfo(). We need to check whether the data is null before using
data.length.
> 2)<code>
> HRegionInfo info = Writables.getHRegionInfoOrNull(
>             rowResult.getValue(HConstants.CATALOG_FAMILY,
>                 HConstants.REGIONINFO_QUALIFIER));
> if(info == null)
>   return false
> </code>
> Any thoughts?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message