hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3762) HTableFactory.releaseHTableInterface() wraps IOException in RuntimeException
Date Mon, 11 Apr 2011 18:24:06 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018481#comment-13018481
] 

jiraposter@reviews.apache.org commented on HBASE-3762:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/574/#review420
-----------------------------------------------------------

Ship it!


Looks good to me. Better to be explicit than throwing a spurious RuntimeException. This makes
the API more coherent.

- Lars


On 2011-04-11 01:45:56, Ted Yu wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/574/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-04-11 01:45:56)
bq.  
bq.  
bq.  Review request for hbase and Gary Helmling.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Currently HTableFactory.releaseHTableInterface() wraps IOException in RuntimeException.
bq.  We should let HTableInterfaceFactory.releaseHTableInterface() throw IOException explicitly.
bq.  
bq.  
bq.  This addresses bug HBASE-3762.
bq.      https://issues.apache.org/jira/browse/HBASE-3762
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java 1090768 
bq.    /src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java 1090768 
bq.    /src/main/java/org/apache/hadoop/hbase/client/HTableInterfaceFactory.java 1090768 
bq.    /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090768 
bq.    /src/main/java/org/apache/hadoop/hbase/rest/RowResource.java 1090768 
bq.    /src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java 1090768 
bq.  
bq.  Diff: https://reviews.apache.org/r/574/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  TestHTablePool and TestAvroServer pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> HTableFactory.releaseHTableInterface() wraps IOException in RuntimeException
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-3762
>                 URL: https://issues.apache.org/jira/browse/HBASE-3762
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.90.2
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>
> Currently HTableFactory.releaseHTableInterface() wraps IOException in RuntimeException.
> We should let HTableInterfaceFactory.releaseHTableInterface() throw IOException explicitly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message