hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3796) Per-Store Entries in Compaction Queue
Date Sat, 30 Apr 2011 20:10:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027367#comment-13027367
] 

stack commented on HBASE-3796:
------------------------------

There's a bit of code dup here:

{code}
@@ -115,7 +119,9 @@ public class CompactSplitThread extends Thread implements CompactionRequestor
{
 
   public synchronized void requestCompaction(final HRegion r,
       final String why) {
-    requestCompaction(r, false, why, r.getCompactPriority());
+    for(Store s : r.getStores().values()) {
+      requestCompaction(r, s, false, why, s.getCompactPriority());
+    }
   }
 
   public synchronized void requestCompaction(final HRegion r,
@@ -123,23 +129,33 @@ public class CompactSplitThread extends Thread implements CompactionRequestor
{
     requestCompaction(r, false, why, p);
   }
 
+  public synchronized void requestCompaction(final HRegion r,
+      final boolean force, final String why, int p) {
+    for(Store s : r.getStores().values()) {
+      requestCompaction(r, s, force, why, p);
+    }
+  }
+ 
{code}

This class is missing a license:

{code}
+++ b/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
{code}

Thanks for breaking out CompactionRequest into class of its own.

Patch looks great.

Let me fix the above, at least the license.

> Per-Store Entries in Compaction Queue
> -------------------------------------
>
>                 Key: HBASE-3796
>                 URL: https://issues.apache.org/jira/browse/HBASE-3796
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Nicolas Spiegelberg
>            Assignee: Karthik Ranganathan
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: HBASE-3796-fixed.patch, HBASE-3796.patch
>
>
> Although compaction is decided on a per-store basis, right now the CompactSplitThread
only deals at the Region level for queueing.  Store-level compaction queue entries will give
us more visibility into compaction workload + allow us to stop summarizing priorities.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message