Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 87532 invoked from network); 24 Mar 2011 23:32:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 24 Mar 2011 23:32:46 -0000 Received: (qmail 44609 invoked by uid 500); 24 Mar 2011 23:32:46 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 44560 invoked by uid 500); 24 Mar 2011 23:32:45 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 44545 invoked by uid 99); 24 Mar 2011 23:32:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2011 23:32:45 +0000 X-ASF-Spam-Status: No, hits=-1999.7 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD,URIBL_RHS_DOB X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2011 23:32:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 034104C67D for ; Thu, 24 Mar 2011 23:32:06 +0000 (UTC) Date: Thu, 24 Mar 2011 23:32:06 +0000 (UTC) From: "Jean-Daniel Cryans (JIRA)" To: issues@hbase.apache.org Message-ID: <1097504316.10200.1301009526010.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1643159677.2807.1300750506030.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-3681) Check the sloppiness of the region load before balancing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011004#comment-13011004 ] Jean-Daniel Cryans commented on HBASE-3681: ------------------------------------------- Some comments: - I think the ifs in the new constructor aren't written consistently with the rest of the code. Usually we either do brackets or one-line ifs and this is neither. - I wouldn't reuse the min/max since they don't have the same meaning. - The comment "so that behavior is consistent with that of 0.90.1." is true but I don't think it belongs in there, since it will go stale very fast. Just saying that here is enough IMO. - I think for 0.92 we could set the slop to something like 0.1 or 0.2, but keep it at 0 for 0.90.1. Regarding that, Stack moved this issue to 0.92 but he agreed we can move it back into 0.90.2 since 1) we need it at SU and 2) it's going to be disabled by default. > Check the sloppiness of the region load before balancing > -------------------------------------------------------- > > Key: HBASE-3681 > URL: https://issues.apache.org/jira/browse/HBASE-3681 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.90.1 > Reporter: Jean-Daniel Cryans > Assignee: Ted Yu > Fix For: 0.92.0 > > Attachments: hbase-3681-v2.txt, hbase-3681.txt > > > Per our discussion at the hackathon today, it seems that it would be more helpful to add a sloppiness check before doing the normal balancing. > The current situation is that the balancer always tries to get the region load even, meaning that there can be some very frequent regions movement. > Setting the balancer to run less often (like every 4 hours) isn't much better since the load could get out of whack easily. > This is why running the normal balancer frequently, but first checking for some sloppiness in the region load across the RS, seems like a more viable option. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira