hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2495) Allow record filtering with selected row key values in HBase Export
Date Tue, 15 Mar 2011 05:24:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006797#comment-13006797
] 

stack commented on HBASE-2495:
------------------------------

Why did you change the comment on the license? You are making it different to all the other
licenses in the code base.

Yeah, you change the comment style elsewhere too... suggest you leave it.

Be careful w/ your formatting here:

{code}
+    if (exportFilter!= null) {
+        LOG.info("Setting Scan Filter for Export.");
+      s.setFilter(exportFilter);
+    }
{code}

Also, we do 80 chars a line usually.

Just FYI.

Would suggest you change name of getExportFilter to getFilter since it can return prefix or
regex?

This patch looks great.  Regards a unit test, that seems a bit tough to do.  What if you pasted
into the issue examples of your exercising this new functionality?  That'd be good enough
I'd say. 

Nice one Ian.


> Allow record filtering with selected row key values in HBase Export
> -------------------------------------------------------------------
>
>                 Key: HBASE-2495
>                 URL: https://issues.apache.org/jira/browse/HBASE-2495
>             Project: HBase
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.20.3
>            Reporter: Ted Yu
>              Labels: moved_from_0_20_5
>             Fix For: 0.92.0
>
>         Attachments: HBASE-2495_-_Allow_record_filtering_with_selected_row_key_values_in_HBase_Export.patch
>
>
> It is desirable to add record filtering capability to HBase Export.
> The following code is an example (s is the Scan):
> 		byte [] prefix = Bytes.toBytes(args[5]);
> 		if (args[5].startsWith("^"))
> 		{
> 			s.setFilter(new RowFilter(CompareOp.EQUAL, new RegexStringComparator(args[5])));
> 		}
> 		else s.setFilter(new PrefixFilter(prefix));

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message