hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3716) Intermittent TestRegionRebalancing failure
Date Thu, 31 Mar 2011 17:09:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014071#comment-13014071
] 

Jean-Daniel Cryans commented on HBASE-3716:
-------------------------------------------

This sort of operation can be done better:

bq. ret = plans != null ? true : false;

All you gotta do is to take the return value of the condition and that's it.

But even then you don't need to add an additional boolean since the next line is:

bq. if (plans != null && !plans.isEmpty()) {

Won't adding a _else_ statement in order to _return false_ be more readable?

> Intermittent TestRegionRebalancing failure
> ------------------------------------------
>
>                 Key: HBASE-3716
>                 URL: https://issues.apache.org/jira/browse/HBASE-3716
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 3716.txt
>
>
> See HBase-TRUNK build #1820
> This could be due to HBASE-3681
> In trunk, default value of "hbase.regions.slop" is 20%. It is possible for load balancer
to see region distribution which falls within 20% of optimal distribution.
> However, assertRegionsAreBalanced() uses 10% slop.
> One solution is to align the slop in assertRegionsAreBalanced() with "hbase.regions.slop"
value.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message