Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 20116 invoked from network); 2 Feb 2011 07:53:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 2 Feb 2011 07:53:54 -0000 Received: (qmail 43045 invoked by uid 500); 2 Feb 2011 07:53:54 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 42947 invoked by uid 500); 2 Feb 2011 07:53:52 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 42939 invoked by uid 99); 2 Feb 2011 07:53:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Feb 2011 07:53:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Feb 2011 07:53:49 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 0024E1894AA for ; Wed, 2 Feb 2011 07:53:29 +0000 (UTC) Date: Wed, 2 Feb 2011 07:53:28 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: <2000227507.4599.1296633208996.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <274797635.657.1296510089836.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Commented: (HBASE-3494) checkAndPut implementation doesnt verify row param and writable row are the same MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989546#comment-12989546 ] Hudson commented on HBASE-3494: ------------------------------- Integrated in HBase-TRUNK #1728 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1728/]) > checkAndPut implementation doesnt verify row param and writable row are the same > -------------------------------------------------------------------------------- > > Key: HBASE-3494 > URL: https://issues.apache.org/jira/browse/HBASE-3494 > Project: HBase > Issue Type: Bug > Affects Versions: 0.90.0 > Reporter: ryan rawson > Assignee: ryan rawson > Fix For: 0.90.1 > > Attachments: HBASE-3494.txt > > > the API checkAndPut, and on the server side checkAndMutate doesn't enforce that the row in the API call and the row in the passed writable that should be executed if the check passes, are the same row! Looking at the code, if someone were to 'fool' us, we'd probably end up with rows in the wrong region in the worst case. Or we'd end up with non-locked puts/deletes to different rows since the checkAndMutate grabs the row lock and calls put/delete methods that do not grab row locks. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira