hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS incorrectly.
Date Fri, 25 Feb 2011 01:10:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999170#comment-12999170
] 

stack commented on HBASE-3423:
------------------------------

Yeah, this is broke.  The hbase-env.sh file is sourced in a few places.  Each sourcing will
double up HBASE_OPTS when we have this in place.  I took a look at hadoop.  It sources hadoop-env
in hadoop script and in hadoop-daemon.  Messing around, this will make for the same tripling
when we have HBASE_OPTS defined as value of whatever HBASE_OPTS currently is (HADOOP_OPTS
does not have HADOOP_OPTS in its value).

Whats the objective?  Being able to get stuff in from the environment?  Generally we do all
in our power to shut out environment settings so we're not exposed to vagaries of the personality
doing a deploy.

> hbase-env.sh over-rides HBASE_OPTS incorrectly.
> -----------------------------------------------
>
>                 Key: HBASE-3423
>                 URL: https://issues.apache.org/jira/browse/HBASE-3423
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.0
>            Reporter: Ted Dunning
>             Fix For: 0.90.0, 0.92.0
>
>
> conf/hbase-env.sh has the following line:
>    export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
> This should be
>    export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC
-XX:+CMSIncrementalMode"

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message