Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 65285 invoked from network); 23 Dec 2010 04:33:28 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Dec 2010 04:33:28 -0000 Received: (qmail 13240 invoked by uid 500); 23 Dec 2010 04:33:28 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 13161 invoked by uid 500); 23 Dec 2010 04:33:28 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 13143 invoked by uid 99); 23 Dec 2010 04:33:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Dec 2010 04:33:28 +0000 X-ASF-Spam-Status: No, hits=-1996.4 required=10.0 tests=ALL_TRUSTED,FS_REPLICA X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Dec 2010 04:33:27 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oBN4X7q0002388 for ; Thu, 23 Dec 2010 04:33:07 GMT Message-ID: <31934608.282191293078787434.JavaMail.jira@thor> Date: Wed, 22 Dec 2010 23:33:07 -0500 (EST) From: "Hudson (JIRA)" To: issues@hbase.apache.org Subject: [jira] Commented: (HBASE-3358) Recovered replication queue wait on themselves when terminating In-Reply-To: <12657256.126321292372161396.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974494#action_12974494 ] Hudson commented on HBASE-3358: ------------------------------- Integrated in HBase-TRUNK #1697 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1697/]) > Recovered replication queue wait on themselves when terminating > --------------------------------------------------------------- > > Key: HBASE-3358 > URL: https://issues.apache.org/jira/browse/HBASE-3358 > Project: HBase > Issue Type: Bug > Reporter: Jean-Daniel Cryans > Assignee: Jean-Daniel Cryans > Fix For: 0.90.0 > > > When I ported the replication code on the new master I broke a few things, and it seems that the threads created for recovered queues never properly terminate because they join on themselves. Easy fix in ReplicationSource: > {code} > - this.terminate("Finished recovering the queue"); > + LOG.info("Finished recovering the queue"); > + this.running = false; > {code} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.