Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 70994 invoked from network); 14 Dec 2010 17:09:27 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 14 Dec 2010 17:09:27 -0000 Received: (qmail 11446 invoked by uid 500); 14 Dec 2010 17:09:27 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 11349 invoked by uid 500); 14 Dec 2010 17:09:26 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 11333 invoked by uid 99); 14 Dec 2010 17:09:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Dec 2010 17:09:25 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Dec 2010 17:09:23 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oBEH91ZS022206 for ; Tue, 14 Dec 2010 17:09:02 GMT Message-ID: <28989238.116631292346541891.JavaMail.jira@thor> Date: Tue, 14 Dec 2010 12:09:01 -0500 (EST) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Subject: [jira] Commented: (HBASE-3348) Allow Observers to completely override base function In-Reply-To: <22993864.101441292281206601.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971314#action_12971314 ] Andrew Purtell commented on HBASE-3348: --------------------------------------- I had a patch ready but it is failing some tests, digging in. > Allow Observers to completely override base function > ---------------------------------------------------- > > Key: HBASE-3348 > URL: https://issues.apache.org/jira/browse/HBASE-3348 > Project: HBase > Issue Type: Sub-task > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Fix For: 0.92.0 > > > Currently an observer can act as a filter or translator but cannot stop a subsequent call down to the base method for get, put, delete, etc. This means an observer cannot completely override the base function. To deal with this we can: > - Change the preXXX methods to return the same type as the postXXX methods, the same return type of the base method. > - Extend {{Coprocessor.Environment}} with methods that get/set a "should continue" flag. > The framework should check the "should continue" flag before calling the base method. If not, just return what was returned by the preXXX method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.