Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <27708866.152881292482981380.JavaMail.jira@thor>
Date: Thu, 16 Dec 2010 02:03:01 -0500 (EST)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Subject: [jira] Commented: (HBASE-3335) Add BitComparator for filtering
In-Reply-To: <32873316.67411292024341079.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971983#action_12971983 ] 

stack commented on HBASE-3335:
------------------------------

The patch looks great Nathanial (Minor which I can fix on commit is that we use two spaces for tabs.. not 4 as you have in test).

Does this fancy new filter work for you?  (It might work in eclipse environment but in distributed hbase it might not?)  You don't have to add it to HbaseObjectWritable?  (See this class for what I mean).

Thanks.

> Add BitComparator for filtering
> -------------------------------
>
>                 Key: HBASE-3335
>                 URL: https://issues.apache.org/jira/browse/HBASE-3335
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>            Reporter: Nathaniel Cook
>            Priority: Minor
>         Attachments: HBASE-3335.patch, HBASE-3335.v2.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> There are many uses cases for setting bits flags and being able filter on those seems like a good idea.
> The BitComparator would take a byte[] and a bitwise operator for its constructor. It would perform the bitwise operation on the column value bytes with the specified byte[]. Then return whether the result was non-zero. 
> Only the CompareOp.EQUAL and CompareOp.NOT_EQUAL would make sense with this comparator.
> The binary bitwise operators that apply  are AND, OR, and XOR. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.