Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 32332 invoked from network); 28 Dec 2010 22:20:27 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Dec 2010 22:20:27 -0000 Received: (qmail 2362 invoked by uid 500); 28 Dec 2010 22:20:27 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 2333 invoked by uid 500); 28 Dec 2010 22:20:27 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 2325 invoked by uid 99); 28 Dec 2010 22:20:26 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Dec 2010 22:20:26 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Dec 2010 22:20:24 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oBSMK2l1001418 for ; Tue, 28 Dec 2010 22:20:02 GMT Message-ID: <26900890.51661293574802646.JavaMail.jira@thor> Date: Tue, 28 Dec 2010 17:20:02 -0500 (EST) From: "Jesse Yates (JIRA)" To: issues@hbase.apache.org Subject: [jira] Updated: (HBASE-3387) Pair does not deep check arrays for equality. In-Reply-To: <4243779.274791293046021659.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesse Yates updated HBASE-3387: ------------------------------- Attachment: HBASE-3387.patch Sorry about the non-working patch - turns out it was b/c git diff (at least in my setup) appends a/ and b/ to the directories of the original and new versions. This means that the patch will necessarily fail. Went back through, edited by hand and double checked that it works this time. Sorry again! > Pair does not deep check arrays for equality. > ---------------------------------------------- > > Key: HBASE-3387 > URL: https://issues.apache.org/jira/browse/HBASE-3387 > Project: HBase > Issue Type: Bug > Components: util > Affects Versions: 0.90.1 > Environment: Any (discovered in Ubuntu 10.10 using TRUNK). > Reporter: Jesse Yates > Priority: Minor > Fix For: 0.90.1 > > Attachments: HBASE-3387.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Pair does not deep check arrays for equality. It merely does x.equals(y) for the sent Object. However, with any type of array this is merely going to compare the array pointers, rather than the underlying data structure. > It requires a rewriting of the private equals method in Pair to check for elements being an array, then checking the underlying elements. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.