hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions
Date Tue, 07 Dec 2010 05:43:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968579#action_12968579

HBase Review Board commented on HBASE-3305:

Message from: stack@duboce.net

This is an automatically generated e-mail. To reply, visit:

Ship it!

Looks good Ted.  Below are a few pointers mostly on formatting and then a few questions. 
Thanks for making the patch.


    Do you need to pollute HMaster with this AssignmentManager inner class?


    FYI, don't make these kinda formatting changes in a patch... its distracting and the change
you are making is against the convention used in the rest of this file.  Just FYI.  No biggie.


    Yeah, maybe these lines belong inside a method that is inside AssignmentManager?  What
you think Ted?


    What changed on this line?  White space?


    Convention is two spaces for tab in hbase and hadoop.  This seems like something else?


    FYI, tab is two spaces... we indent in multiples of two spaces.


    Good.  Nice test.

- stack

> Allow round-robin distribution for table created with multiple regions
> ----------------------------------------------------------------------
>                 Key: HBASE-3305
>                 URL: https://issues.apache.org/jira/browse/HBASE-3305
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 0.20.6
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: hbase-3305-array.patch, hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch,
> We can distribute the initial regions created for a new table in round-robin fashion.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message