hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions
Date Tue, 07 Dec 2010 05:43:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968579#action_12968579
] 

HBase Review Board commented on HBASE-3305:
-------------------------------------------

Message from: stack@duboce.net

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/#review2037
-----------------------------------------------------------

Ship it!


Looks good Ted.  Below are a few pointers mostly on formatting and then a few questions. 
Thanks for making the patch.


trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1271/#comment6430>

    Do you need to pollute HMaster with this AssignmentManager inner class?



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1271/#comment6431>

    FYI, don't make these kinda formatting changes in a patch... its distracting and the change
you are making is against the convention used in the rest of this file.  Just FYI.  No biggie.



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1271/#comment6432>

    Yeah, maybe these lines belong inside a method that is inside AssignmentManager?  What
you think Ted?



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1271/#comment6433>

    What changed on this line?  White space?



trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java
<http://review.cloudera.org/r/1271/#comment6434>

    Convention is two spaces for tab in hbase and hadoop.  This seems like something else?



trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
<http://review.cloudera.org/r/1271/#comment6435>

    FYI, tab is two spaces... we indent in multiples of two spaces.



trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
<http://review.cloudera.org/r/1271/#comment6437>

    Good.  Nice test.


- stack





> Allow round-robin distribution for table created with multiple regions
> ----------------------------------------------------------------------
>
>                 Key: HBASE-3305
>                 URL: https://issues.apache.org/jira/browse/HBASE-3305
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 0.20.6
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: hbase-3305-array.patch, hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch,
hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message