hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3256) Coprocessors: Coprocessor host and observer for HMaster
Date Tue, 21 Dec 2010 05:38:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973477#action_12973477
] 

HBase Review Board commented on HBASE-3256:
-------------------------------------------

Message from: "Gary Helmling" <ghelmling@gmail.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1321/#review2130
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
<http://review.cloudera.org/r/1321/#comment6621>

    It actually means "region".  That conf key is only used for the system coprocessors loaded
on regions.
    
    I'll change the name (and config property).



src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
<http://review.cloudera.org/r/1321/#comment6622>

    Yes, I'm not sure what the original intent was here, obtaining the CP without the full
package name?
    
    Maybe getClass().getSimpleName().equals() would be better?



src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1321/#comment6623>

    This is the result of env.shouldBypass(), in order to allow a MasterObserver to bypass
the normal balance() processing.



src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1321/#comment6624>

    Right, that's the only way to modify the input.  Will change.



src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1321/#comment6628>

    I can add in env.shouldBypass() handling here to allow overriding.  Combined with access
to ServerManager through MasterServices, this should allow custom assignment policies.



src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<http://review.cloudera.org/r/1321/#comment6629>

    Yes, will add in env.shouldBypass() handling here too.


- Gary





> Coprocessors: Coprocessor host and observer for HMaster
> -------------------------------------------------------
>
>                 Key: HBASE-3256
>                 URL: https://issues.apache.org/jira/browse/HBASE-3256
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Andrew Purtell
>            Assignee: Gary Helmling
>             Fix For: 0.92.0
>
>         Attachments: HBASE-3256_initial.patch
>
>
> Implement a coprocessor host for HMaster. Hook observers into administrative operations
performed on tables: create, alter, assignment, load balance, and allow observers to modify
base master behavior. Support automatic loading of coprocessor implementation. 
> Consider refactoring the master coprocessor host and regionserver coprocessor host into
a common base class. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message