hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3400) Coprocessor Support for Generic Interfaces
Date Thu, 30 Dec 2010 01:29:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975949#action_12975949

Gary Helmling commented on HBASE-3400:

Thanks for the patch, Ed!

It looks like the diff contains some of your changes from HBASE-3316, which are now in trunk.
 Can you redo the diff from the latest trunk and also post to review.hbase.org?  Thanks again.

> Coprocessor Support for Generic Interfaces
> ------------------------------------------
>                 Key: HBASE-3400
>                 URL: https://issues.apache.org/jira/browse/HBASE-3400
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Ed Kohlwey
>            Assignee: Ed Kohlwey
>         Attachments: HBASE-3400.patch
> Coprocessors currently do not support generic interfaces because type erasure makes their
generic parameters appear as Objects to Invocation.java.
> This can be overcome by writing out the parameters using their own types (rather than
the type parameters), and then separately writing the class names for the type parameters.
While it would be ideal to implement this in Invocation.java, some other code seems to be
relying on its write order and doing so breaks other RPC code. The modification can, however,
be implemented in Exec.java instead.
> The included patch modifies Invocation.java's fields to that they are protected scope,
and fully implements the read and write methods for Exec rather than using the parent method
for the parent fields. ExecResult is also modified to accommodate generic returns in the same

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message