hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3291) If split happens while regionserver is going down, we can stick open.
Date Wed, 01 Dec 2010 22:54:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965902#action_12965902
] 

Jean-Daniel Cryans commented on HBASE-3291:
-------------------------------------------

Found two issues:

{code}
+    while (isOnlineRegionsEmpty()) {
{code}

should check if it's not empty, else it loops forever.

{code}
+    HRegion r = null;
+    synchronized (this.onlineRegions) {
+      this.onlineRegions.get(encodedRegionName);
+    }
{code}

is missing the assignment of "r", else the web page NPEs.

So with both corrected and when I'm not hitting HBASE-3298, the patch works.

> If split happens while regionserver is going down, we can stick open.
> ---------------------------------------------------------------------
>
>                 Key: HBASE-3291
>                 URL: https://issues.apache.org/jira/browse/HBASE-3291
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.0
>
>         Attachments: closing.txt
>
>
> J-D found this one testing.  He found that if a split comes in during shutdown of a regionserver,
then the regionserver can stick open... and won't go down.
> We fixed a similar problem in the past where if balancer cut in during shutdown and assigned
a regionserver an region during shutdown, we'd open it and it'd cause us again to stick open.
 We fixed that by introducing the 'closing' state.
> Fix for the issue j-d found is to do closing check when onlining daughters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message