Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 72479 invoked from network); 22 Nov 2010 23:52:05 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 Nov 2010 23:52:05 -0000 Received: (qmail 75819 invoked by uid 500); 22 Nov 2010 23:52:37 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 75794 invoked by uid 500); 22 Nov 2010 23:52:37 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 75786 invoked by uid 99); 22 Nov 2010 23:52:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Nov 2010 23:52:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Nov 2010 23:52:36 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oAMNqGtO022725 for ; Mon, 22 Nov 2010 23:52:16 GMT Message-ID: <6812490.246061290469936008.JavaMail.jira@thor> Date: Mon, 22 Nov 2010 18:52:16 -0500 (EST) From: "Jonathan Gray (JIRA)" To: issues@hbase.apache.org Subject: [jira] Commented: (HBASE-3261) NPE out of HRS.run at startup when clock is out of sync In-Reply-To: <925085.245821290468734371.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934664#action_12934664 ] Jonathan Gray commented on HBASE-3261: -------------------------------------- Yeah this is something I had to add a lot of checks for in HMaster as well. +1 on adding null checks before we stop/interrupt stuff. > NPE out of HRS.run at startup when clock is out of sync > ------------------------------------------------------- > > Key: HBASE-3261 > URL: https://issues.apache.org/jira/browse/HBASE-3261 > Project: HBase > Issue Type: Bug > Reporter: Jean-Daniel Cryans > Fix For: 0.90.0, 0.92.0 > > > This is what I get when I start a region server that's not properly sync'ed: > {noformat} > Exception in thread "regionserver60020" java.lang.NullPointerException > at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:603) > at java.lang.Thread.run(Thread.java:637) > {noformat} > I this case the line was: > {noformat} > hlogRoller.interruptIfNecessary(); > {noformat} > I guess we could add a bunch of other null checks. > The end result is the same, the RS dies, but I think it's misleading. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.