Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 58742 invoked from network); 9 Nov 2010 00:00:04 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 9 Nov 2010 00:00:04 -0000 Received: (qmail 54186 invoked by uid 500); 9 Nov 2010 00:00:36 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 54165 invoked by uid 500); 9 Nov 2010 00:00:36 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 54157 invoked by uid 99); 9 Nov 2010 00:00:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Nov 2010 00:00:36 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Nov 2010 00:00:33 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oA900BR3000312 for ; Tue, 9 Nov 2010 00:00:11 GMT Message-ID: <6253128.89431289260811586.JavaMail.jira@thor> Date: Mon, 8 Nov 2010 19:00:11 -0500 (EST) From: "HBase Review Board (JIRA)" To: issues@hbase.apache.org Subject: [jira] Commented: (HBASE-3208) HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too In-Reply-To: <4985814.88551289259611993.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929837#action_12929837 ] HBase Review Board commented on HBASE-3208: ------------------------------------------- Message from: "Kannan Muthukkaruppan" ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1188/#review1850 ----------------------------------------------------------- Ship it! Make sense. LGTM. - Kannan > HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too > ---------------------------------------------------------------------------------- > > Key: HBASE-3208 > URL: https://issues.apache.org/jira/browse/HBASE-3208 > Project: HBase > Issue Type: Bug > Reporter: Jean-Daniel Cryans > Assignee: Jean-Daniel Cryans > Priority: Blocker > Fix For: 0.90.0 > > > Follow up to HBASE-3198, now that we are doing the right thing it seems that TestWALObserver is throwing NPEs. Digging in more, I figured that HLog.findMemstoresWithEditsOlderThan actually needs to be looking at edits that are equal or older rather than just older since logs with only 1 edit won't get any regions to flush. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.