Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <32594863.34211291148896989.JavaMail.jira@thor>
Date: Tue, 30 Nov 2010 15:28:16 -0500 (EST)
From: "HBase Review Board (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Subject: [jira] Commented: (HBASE-3286) Master passes IP and not hostname
 back to region server
In-Reply-To: <16546772.13381291075631303.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965410#action_12965410 ] 

HBase Review Board commented on HBASE-3286:
-------------------------------------------

Message from: "Jonathan Gray" <jgray@apache.org>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1262/#review2012
-----------------------------------------------------------

Ship it!


A little confused by the discrepancy between String host / int port and the Address.  But does seem fine given we don't actually access the string/int values and always use the address object.

Do we need some tests on this stuff?  Seems like we always have issues here but tests don't catch anything.

Looks better than what we have though so I'm +1 regardless.


/trunk/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
<http://review.cloudera.org/r/1262/#comment6351>

    Why does stringValue not necessarily equal the host:port we store in those Strings?  Shouldn't they be the same?


/trunk/src/main/java/org/apache/hadoop/hbase/HServerAddress.java
<http://review.cloudera.org/r/1262/#comment6352>

    But on serialization, we use the address hostname not the thing we actually store in hostname/port variables, so after serialized it's different?
    
    Shouldn't we set the hostname/port variables on construction according to address.getAddress/getPort rather than the passed values, if the address values are what we want to use?


/trunk/src/main/java/org/apache/hadoop/hbase/HServerInfo.java
<http://review.cloudera.org/r/1262/#comment6353>

    I guess we never actually use the String host / int port?  Why do we store them in HServerAddress then?


/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.cloudera.org/r/1262/#comment6354>

    whitespace


- Jonathan


> Master passes IP and not hostname back to region server
> -------------------------------------------------------
>
>                 Key: HBASE-3286
>                 URL: https://issues.apache.org/jira/browse/HBASE-3286
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.90.0
>
>
> Starting my little test cluster on the latest from 0.90, I see:
> {noformat}
> 2010-11-29 23:21:34,131 INFO org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 1024 region(s) across 9 server(s), retainAssignment=true
> 2010-11-29 23:21:34,134 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 22 region(s) to sv2borg181,61020,1291072886282
> 2010-11-29 23:21:34,135 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 24 region(s) to sv2borg182,61020,1291072885473
> 2010-11-29 23:21:34,135 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 37 region(s) to sv2borg183,61020,1291072885646
> 2010-11-29 23:21:34,135 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 25 region(s) to sv2borg184,61020,1291072886734
> 2010-11-29 23:21:34,135 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 26 region(s) to sv2borg185,61020,1291072886606
> 2010-11-29 23:21:34,136 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 70 region(s) to sv2borg186,61020,1291072885486
> 2010-11-29 23:21:34,136 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 30 region(s) to sv2borg187,61020,1291072886355
> 2010-11-29 23:21:34,136 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 89 region(s) to sv2borg188,61020,1291072885926
> 2010-11-29 23:21:34,136 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 701 region(s) to sv2borg189,61020,1291072886739
> {noformat}
> After another restart:
> {noformat}
> 2010-11-30 00:03:38,100 INFO org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 1024 region(s) across 9 server(s), retainAssignment=true
> 2010-11-30 00:03:38,103 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 71 region(s) to sv2borg181,61020,1291075409984
> 2010-11-30 00:03:38,103 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 82 region(s) to sv2borg182,61020,1291075409956
> 2010-11-30 00:03:38,104 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 61 region(s) to sv2borg183,61020,1291075409952
> 2010-11-30 00:03:38,104 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 122 region(s) to sv2borg184,61020,1291075409957
> 2010-11-30 00:03:38,104 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 59 region(s) to sv2borg185,61020,1291075409955
> 2010-11-30 00:03:38,104 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 71 region(s) to sv2borg186,61020,1291075409963
> 2010-11-30 00:03:38,105 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 52 region(s) to sv2borg187,61020,1291075411049
> 2010-11-30 00:03:38,105 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 254 region(s) to sv2borg188,61020,1291075410360
> 2010-11-30 00:03:38,105 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Bulk assigning 252 region(s) to sv2borg189,61020,1291075409959
> {noformat}
> I also saw one time where everything was assigned to 189.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.