hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3246) Add API to Increment client class that increments rather than replaces the amount for a column when done multiple times
Date Thu, 18 Nov 2010 19:52:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933546#action_12933546
] 

Jonathan Gray commented on HBASE-3246:
--------------------------------------

Writing the javadoc for these methods, it seems like people could get easily confused.  Probably
should have called the original method {{incrementColumn()}} and then just add a second method
w/ a boolean about whether you want to sum with existing or replace existing.

Will put up a patch with what I came up based on my original description with but could use
some input from others.

> Add API to Increment client class that increments rather than replaces the amount for
a column when done multiple times
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3246
>                 URL: https://issues.apache.org/jira/browse/HBASE-3246
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>
> In the new Increment class, the API to add columns is {{addColumn()}}.  If you do this
multiple times for an individual column, the amount to increment by is replaced.  I think
this is the right way for this method to work and it is javadoc'd with the behavior.
> We should add a new method, {{incrementColumn()}} which will increment any existing amount
for the specified column rather than replacing it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message