hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3211) Key (Index) Only Fetches
Date Thu, 11 Nov 2010 01:16:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930880#action_12930880
] 

HBase Review Board commented on HBASE-3211:
-------------------------------------------

Message from: "Nicolas" <nspiegelberg@facebook.com>


bq.  On 2010-11-10 16:01:22, Nicolas wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java, line 1199
bq.  > <http://review.cloudera.org/r/1208/diff/1/?file=17147#file17147line1199>
bq.  >
bq.  >     Would it be more straightforward to have a ReturnCode.MODIFY, that signals an
include but suggests that the program must call modifyKeyValue() to get the transformed data.
 Maybe this is too much of a one-off case...
bq.  
bq.  Jonathan Gray wrote:
bq.      Not sure I completely follow.  You're saying the modification would happen outside
the filter?  No one needs to call modifyKeyValue() to get the transformed data, it's done
in the filter.
bq.      
bq.      In any case, yeah, I would not be for adding another ReturnCode just for this.

I suggested this alternative because users normally expect filters to do immutable operations
on the data itself, and you're introducing side effects.  If we stay with this paradigm, it's
probably best to add a note in Filter.filterKeyValue() that the KeyValue may be modified.


- Nicolas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1208/#review1896
-----------------------------------------------------------





> Key (Index) Only Fetches
> ------------------------
>
>                 Key: HBASE-3211
>                 URL: https://issues.apache.org/jira/browse/HBASE-3211
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Jonathan Gray
>             Fix For: 0.90.0
>
>         Attachments: HBASE-3211-v2.patch, HBASE-3211-v3.patch
>
>
> When you retrieve data from HBase you get Key (Row+Column+Timestamp) + Values. 
> It would be nice to have a mode where we only fetch the keys (i.e. the index) but not
the values.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message