hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3208) HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too
Date Tue, 09 Nov 2010 00:00:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929837#action_12929837
] 

HBase Review Board commented on HBASE-3208:
-------------------------------------------

Message from: "Kannan Muthukkaruppan" <kannan@facebook.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1188/#review1850
-----------------------------------------------------------

Ship it!


Make sense. LGTM.


- Kannan





> HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-3208
>                 URL: https://issues.apache.org/jira/browse/HBASE-3208
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Blocker
>             Fix For: 0.90.0
>
>
> Follow up to HBASE-3198, now that we are doing the right thing it seems that TestWALObserver
is throwing NPEs. Digging in more, I figured that HLog.findMemstoresWithEditsOlderThan actually
needs to be looking at edits that are equal or older rather than just older since logs with
only 1 edit won't get any regions to flush.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message