hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3213) If do abort of backup master will get NPE instead of graceful abort
Date Wed, 10 Nov 2010 01:59:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930426#action_12930426
] 

Jonathan Gray commented on HBASE-3213:
--------------------------------------

Fix:

{noformat}
--- src/main/java/org/apache/hadoop/hbase/master/HMaster.java	(revision 1033306)
+++ src/main/java/org/apache/hadoop/hbase/master/HMaster.java	(working copy)
@@ -278,7 +278,8 @@
       stopChores();
       // Wait for all the remaining region servers to report in IFF we were
       // running a cluster shutdown AND we were NOT aborting.
-      if (!this.abort && this.serverManager.isClusterShutdown()) {
+      if (!this.abort && this.serverManager != null &&
+          this.serverManager.isClusterShutdown()) {
         this.serverManager.letRegionServersShutdown();
       }
       stopServiceThreads();
{noformat}

Will commit if someone gives me +1

> If do abort of backup master will get NPE instead of graceful abort
> -------------------------------------------------------------------
>
>                 Key: HBASE-3213
>                 URL: https://issues.apache.org/jira/browse/HBASE-3213
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.90.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Minor
>             Fix For: 0.90.0
>
>
> Doesn't really matter because it's aborting the server anyways, but I've seen it on TestMasterFailover.
 Simple fix.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message