hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3232) Fix KeyOnlyFilter + Add Value Length
Date Sat, 13 Nov 2010 05:18:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931630#action_12931630
] 

HBase Review Board commented on HBASE-3232:
-------------------------------------------

Message from: "Nicolas" <nspiegelberg@facebook.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1213/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

HBASE-3211 altered filter code to mutate KeyValues. What could go wrong? Well, your scan could
mess up because the KVHeap compare functions don't work properly. If we're going to soft mutate
KVs in filter code, we also need to soft copy the KV before filtering. This was found while
adding the ability to have KeyOnlyFilter have the option to return the Value's length. This
is useful for grouping your reduce tasks into equal-sized blocks.


This addresses bug HBASE-3232.
    http://issues.apache.org/jira/browse/HBASE-3232


Diffs
-----

  trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java 1034646 
  trunk/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java 1034646 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 1034646 
  trunk/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java 1034646 
  trunk/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java 1034646 

Diff: http://review.cloudera.org/r/1213/diff


Testing
-------

mvn clean test


Thanks,

Nicolas




> Fix KeyOnlyFilter + Add Value Length
> ------------------------------------
>
>                 Key: HBASE-3232
>                 URL: https://issues.apache.org/jira/browse/HBASE-3232
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Blocker
>             Fix For: 0.90.0
>
>
> HBASE-3211 altered filter code to mutate KeyValues.  What could go wrong?  Well, your
scan could mess up because the KVHeap compare functions don't work properly.  If we're going
to soft mutate KVs in filter code, we also need to soft copy the KV before filtering.  This
was found while adding the ability to have KeyOnlyFilter have the option to return the Value's
length.  This is useful for grouping your reduce tasks into equal-sized blocks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message