hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3211) Key (Index) Only Fetches
Date Wed, 10 Nov 2010 23:32:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930831#action_12930831
] 

HBase Review Board commented on HBASE-3211:
-------------------------------------------

Message from: "Jonathan Gray" <jgray@apache.org>


bq.  On 2010-11-10 15:24:52, stack wrote:
bq.  > Looks fine to me.  That kv copy is ugly but what else can you do?

Definitely can't modify the original buffer, so it's the only choice.

In this case, it's not a huge deal because we'll do these allocations, return the result,
and then immediately be done with the memory and will have no references to it.  Should be
okay on GC.

One potential optimization would be to do one big rewrite of the KVs at the end rather as
we go.  Instead of allocating individual byte[] for each KV, you could potentially do one
big byte[] behind all the key-only KVs.  This gets way more complicated and I'm not sure it's
worth it.  Was going for minimal approach.

In the filter unit test, I'm also going add an additional assert on commit (and verifying
still passes).  The test verifies the values are not the same but we should actually explicitly
also assert that the value is 0 length.

Thanks!


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1208/#review1890
-----------------------------------------------------------





> Key (Index) Only Fetches
> ------------------------
>
>                 Key: HBASE-3211
>                 URL: https://issues.apache.org/jira/browse/HBASE-3211
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Jonathan Gray
>
> When you retrieve data from HBase you get Key (Row+Column+Timestamp) + Values. 
> It would be nice to have a mode where we only fetch the keys (i.e. the index) but not
the values.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message