hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3112) Enable and disable of table needs a bit of loving in new master
Date Mon, 08 Nov 2010 20:03:06 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929703#action_12929703
] 

HBase Review Board commented on HBASE-3112:
-------------------------------------------

Message from: stack@duboce.net


bq.  On 2010-11-08 11:50:55, Jonathan Gray wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java, line
1143
bq.  > <http://review.cloudera.org/r/1187/diff/1/?file=16872#file16872line1143>
bq.  >
bq.  >     What does this mean?  done vs. not done?  I think we should be more descriptive
in the logging (if done, then we've completed assignment of regions on cluster startup). 
But if not done, on startup, what does this mean?  There's comment later that RIT timeouts
should fix it up, so should be in log message here?  Or on startup case of bulk assign, should
we fail startup here if this doesn't pass?

Removed it.  It confuses (see above for exhibit A).

If problem doing bulk assign, we'll crash out master.  Otherwise, timeout of RIT should fix
bulk assign stragglers.


bq.  On 2010-11-08 11:50:55, Jonathan Gray wrote:
bq.  > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java, line
1149
bq.  > <http://review.cloudera.org/r/1187/diff/1/?file=16872#file16872line1149>
bq.  >
bq.  >     Can we move all this stuff into a separate class?  AssignmentManager is getting
huge.  Maybe BulkAssign could be class that contains all these other class definitions?
bq.  >     
bq.  >     Also gives good opportunity in class comment to describe in general how this
stuff works.

BulkAssigner class comment says -- perhaps a little curtly -- what it does?  I'll move it
out.  The implementations though I'll leave beside where they are used -- in class.


- stack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1187/#review1840
-----------------------------------------------------------





> Enable and disable of table needs a bit of loving in new master
> ---------------------------------------------------------------
>
>                 Key: HBASE-3112
>                 URL: https://issues.apache.org/jira/browse/HBASE-3112
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>             Fix For: 0.90.0
>
>         Attachments: 3112-v2.txt, 3112-v3.txt, 3112.txt
>
>
> The tools are in place to do a more reliable enable/disable of tables.  Some work has
been done to hack in a basic enable/disable but its not enough -- see the test avro/thrift
tests where a disable/enable/disable switchback can confuse the table state (and has been
disabled until this issue addressed).
> This issue is about finishing off enable/disable in the new master.   I think we need
to add to the table znode an enabling/disabling state rather than have them binary with a
watcher that will stop an enable (or disable) starting until the previous completes (Currently
we atomically switch the state though the region close/open lags -- some work in enable/disable
handlers helps in that they won't complete till all regions have transitioned.. but its not
enough).
> Need to add tests too.
> Marking issue critical bug because loads of the questions we get on lists are about enable/disable
probs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message