hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3194) HBase should run on both secure and vanilla versions of Hadoop 0.20
Date Tue, 09 Nov 2010 01:20:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929867#action_12929867
] 

HBase Review Board commented on HBASE-3194:
-------------------------------------------

Message from: "Gary Helmling" <ghelmling@gmail.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1184/
-----------------------------------------------------------

(Updated 2010-11-08 17:18:26.166428)


Review request for hbase.


Changes
-------

Added some notes on additional testing.


Summary
-------

Adds a wrapper class, org.apache.hadoop.hbase.security.User, around org.apache.hadoop.security.UserGroupInformation,
to accommodate the divergent APIs of both regular Hadoop 0.20, and secure Hadoop 0.20 (which
should also mean 0.21 and later, though I haven't specifically tested that).

Common methods in both UserGroupInformation versions are invoked directly.  Version specific
methods are invoked using reflection.  Almost all of the usage is around testing code that
spins up local clusters, since those are the only parts that exercise UserGroupInformation
currently.


This addresses bug HBASE-3194.
    http://issues.apache.org/jira/browse/HBASE-3194


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 9267679 
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java e4c356d 
  src/main/java/org/apache/hadoop/hbase/security/User.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 83ceac9 
  src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 8f9c88f 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java d436e2e 
  src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java b9902f1 
  src/test/java/org/apache/hadoop/hbase/security/TestUser.java PRE-CREATION 

Diff: http://review.cloudera.org/r/1184/diff


Testing (updated)
-------

Ran full test suite with these changes against both Hadoop 0.20-append and yahoo-0.20.104-append
(security+append).  The only failures match what I'm currently seeing in trunk.  Will remerge
from trunk and test against as soon as it's back to passing.

Though this is only testing compatibility with both versions with a rebuild.  I still need
to test building against 0.20-append then spinning up HBase using security.  Will do that
next, just wanted to get some eyes on this to validate the approach.

[Update 11/8/2010]: I did some further testing.  Compiled HBase against 0.20-append.  Ran
YCSB with the compiled HBase against Hadoop 0.20.2 and yahoo-0.20.104-append (updating just
the hadoop jar), to verify the patch will work against both without rebuilding.  YCSB load
and varied workloads completed without any errors.


Thanks,

Gary




> HBase should run on both secure and vanilla versions of Hadoop 0.20
> -------------------------------------------------------------------
>
>                 Key: HBASE-3194
>                 URL: https://issues.apache.org/jira/browse/HBASE-3194
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Gary Helmling
>
> There have been a couple cases recently of folks trying to run HBase trunk (or 0.89 DRs)
on CDH3b3 or secure Hadoop.    While HBase security is in the works, it currently only runs
on secure Hadoop versions.  Meanwhile HBase trunk won't compile on secure Hadoop due to backward
incompatible changes in org.apache.hadoop.security.UserGroupInformation.
> This issue is to work out the minimal set of changes necessary to allow HBase to build
and run on both secure and non-secure versions of Hadoop.  Though, with secure Hadoop, I don't
even think it's important to target running with HDFS security enabled (and krb authentication).
 Just allow HBase to build and run in both versions.
> I think mainly this amounts to abstracting usage of UserGroupInformation and UnixUserGroupInformation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message