hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HBASE-3249) Typing 'help shutdown' in the shell shouldn't shutdown the cluster
Date Tue, 23 Nov 2010 21:22:13 GMT

     [ https://issues.apache.org/jira/browse/HBASE-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

stack updated HBASE-3249:

    Attachment: shutdown.txt

I took a quick look.  'help shutdown' is being interpreted as two commands, an 'help' followed
by a 'shutdown'.  The interpreter is running the 'shutdown' command first and then 'help'.
 'help' is a native IRB that we did some hackery to override.  The 'shutdown' is part of our
command-set injection.  I'd need to dig in and spend some time figuring how I hacked this

For 0.90.0, I propose the following patch where we just remove the shutdown command.  Shutdown
from inside the shell seems 'odd' to me.  Meantime I'll open an issue to look into how this
help stuff is being interpreted by IRB.  Its kinda ugly.  If you do 'help get' you get first
complaint that get has not been passed enough parameters and then the help output followed
by the total help output.  Ugly.  We need to fix.  But don't think it blocker on 0.90 RC.

> Typing 'help shutdown' in the shell shouldn't shutdown the cluster
> ------------------------------------------------------------------
>                 Key: HBASE-3249
>                 URL: https://issues.apache.org/jira/browse/HBASE-3249
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.90.0
>         Attachments: shutdown.txt
> _hp_ on IRC found out the bad way that typing 'help shutdown' actually gives you the
full help... and shuts down the cluster. I don't really understand why we process both commands,
putting against 0.90.0 if anyone has an idea.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message