hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ryan rawson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1744) Thrift server to match the new java api.
Date Sun, 17 Oct 2010 23:19:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921920#action_12921920
] 

ryan rawson commented on HBASE-1744:
------------------------------------

i would be against the thrift2 and package moving stuff.  It would require our users to start
a particular version of thrift depending on which one they wanted, and would make it difficult
for users to migrate, unless you also came up with a way to run both .thrift files in 1 server.

Thrift doesnt appear to offer any @deprecated tags, so we are probably going to have to do
this the old fashioned way.

But even so, I think the timeline to remove the old API is pretty aggressive.  We removed
BatchUpdate fairly quickly, and unless there is a compelling reason I'd rather keep old APIs
around just a bit longer. Makes transition easier since it gives users more time.  

> Thrift server to match the new java api.
> ----------------------------------------
>
>                 Key: HBASE-1744
>                 URL: https://issues.apache.org/jira/browse/HBASE-1744
>             Project: HBase
>          Issue Type: Improvement
>          Components: thrift
>            Reporter: Tim Sell
>            Assignee: Lars Francke
>            Priority: Critical
>             Fix For: 0.92.0
>
>         Attachments: HBASE-1744.preview.1.patch, thriftexperiment.patch
>
>
> This mutateRows, etc.. is a little confusing compared to the new cleaner java client.
> Thinking of ways to make a thrift client that is just as elegant. something like:
> void put(1:Bytes table, 2:TPut put) throws (1:IOError io)
> with:
> struct TColumn {
>   1:Bytes family,
>   2:Bytes qualifier,
>   3:i64 timestamp
> }
> struct TPut {
>   1:Bytes row,
>   2:map<TColumn, Bytes> values
> }
> This creates more verbose rpc  than if the columns in TPut were just map<Bytes, map<Bytes,
Bytes>>, but that is harder to fit timestamps into and still be intuitive from say python.
> Presumably the goal of a thrift gateway is to be easy first.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message