hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3053) Add ability to have multiple Masters LocalHBaseCluster for test writing
Date Wed, 06 Oct 2010 21:59:30 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918701#action_12918701
] 

HBase Review Board commented on HBASE-3053:
-------------------------------------------

Message from: "Jonathan Gray" <jgray@apache.org>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/925/
-----------------------------------------------------------

(Updated 2010-10-06 14:35:17.785727)


Review request for hbase, stack, Karthik Ranganathan, and Kannan Muthukkaruppan.


Changes
-------

Changes names of state variables/methods in HMaster to be more explicit.  isActiveMaster and
isInitialized now.

Also removes the last warning in HMaster related to using deprecated RemoteException unwrapping
methods.


Summary
-------

To really be able to unit test the new master properly, we need to be able to have multiple
masters running at once within a single logical cluster.

Also exposes methods to get the currently active master and can access each individually in
the same way that it's done for multiple RS.

This is mostly duplicating what we do for RS but for masters.


This addresses bug HBASE-3053.
    http://issues.apache.org/jira/browse/HBASE-3053


Diffs (updated)
-----

  trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 1004853 
  trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 1004853 
  trunk/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 1004853 
  trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java PRE-CREATION


Diff: http://review.cloudera.org/r/925/diff


Testing
-------

Untested but compiles.  This is first go at a patch.  I'm going to work on writing a new unit
test that uses this next.


Thanks,

Jonathan




> Add ability to have multiple Masters LocalHBaseCluster for test writing
> -----------------------------------------------------------------------
>
>                 Key: HBASE-3053
>                 URL: https://issues.apache.org/jira/browse/HBASE-3053
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, test
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.90.0
>
>         Attachments: HBASE-3053-v11.patch
>
>
> To really be able to unit test the new master properly, we need to be able to have multiple
masters running at once within a single logical cluster.
> Should expose some methods like getActiveMaster() and isActiveMaster() as well as a simple
way to kill an individual master / kill the active master.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message