hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Spiegelberg (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3084) HLog splitLog : Properly Handle User Interrupts
Date Tue, 05 Oct 2010 22:27:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918272#action_12918272
] 

Nicolas Spiegelberg commented on HBASE-3084:
--------------------------------------------

My opinion: FSUtils.recoverFileLease() should throw an InterruptedIOException if it catches
a user interrupt.  There are multiple sections of HBase code that ignore interrupts (*sadness*)
but this area is pretty critical since it can lead to data loss if handled incorrectly.

> HLog splitLog : Properly Handle User Interrupts
> -----------------------------------------------
>
>                 Key: HBASE-3084
>                 URL: https://issues.apache.org/jira/browse/HBASE-3084
>             Project: HBase
>          Issue Type: Bug
>          Components: io, master
>    Affects Versions: 0.89.20100924, 0.90.0, 0.92.0
>            Reporter: stack
>
> Nicolas reviewed HBASE-2437 after it had been committed and raised some issues that need
addressing.  The main issue is that splitLog will ignore user interrupts (aka: InterruptException).
 Currently, data loss can occur (with 'skip.errors' == true) if a user calls 'kill <master-pid>"
during splits because the code will consider the interrupted file completely split.  If the
master receives an interrupt during splitLog, it needs to abort splitting, delete all partially-complete
split files, and exit gracefully.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message