hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3119) [rest] publish endpoint and statistics into ZooKeeper
Date Tue, 19 Oct 2010 00:04:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922372#action_12922372
] 

HBase Review Board commented on HBASE-3119:
-------------------------------------------

Message from: "Jonathan Gray" <jgray@apache.org>


bq.  On 2010-10-18 15:34:45, Ryan Rawson wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java, line 217
bq.  > <http://review.cloudera.org/r/1039/diff/1/?file=14874#file14874line217>
bq.  >
bq.  >     this looks clever, is it more generically useful to other parts of hbase?
bq.  
bq.  Andrew Purtell wrote:
bq.      Other parts of HBase use ZKW methods to do this. I brought this in here to do the
same without pulling in all of the behavior of ZKW I didn't want.
bq.  
bq.  Jonathan Gray wrote:
bq.      Which behaviors of ZKW are you referring to?  Hopefully this component is generally
reusable (the new ZooKeeperWatcher) and could be used even in limited contexts.  Using it
as the primary watcher and registering with it also helps when writing unit test.  You'd then
use ZKUtil methods for this kind of stuff and inherit work done there.
bq.      
bq.      We are going to need one more level underneath ZKUtil or underlying ZKUtil that manages
retry policies and such.  I'm going to target that for 0.92.  And if all our code uses these
APIs then it will be easier to be consistent.
bq.      
bq.      The patch looks fine to me though so we can work at unifying later and not blocking
you on this.
bq.  
bq.  Jonathan Gray wrote:
bq.      It also forces u into good behavior, for example, by needing to pass it an Abortable
on construction.
bq.  
bq.  Andrew Purtell wrote:
bq.      One issue is the constructor creates or checks znodes that the REST interface should
not care about. (I'm thinking ahead to when ZK ACLs are in use a bit maybe.) Also I wanted
automatic retry behavior for setData but that is something for which a wrapper around ZKUtil
method calls would work. 
bq.      
bq.      Unifying later should not be a big deal.

Good point, totally agree.  That definitely does not belong in the ZKW constructor.  The first
master should do it and that's it.  Filed HBASE-3123.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1039/#review1560
-----------------------------------------------------------





> [rest] publish endpoint and statistics into ZooKeeper
> -----------------------------------------------------
>
>                 Key: HBASE-3119
>                 URL: https://issues.apache.org/jira/browse/HBASE-3119
>             Project: HBase
>          Issue Type: Improvement
>          Components: rest
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 0.20.7, 0.92.0
>
>         Attachments: HBASE-3119.patch
>
>
> This change allows the REST interface to publish its endpoint and metrics, currently
only requests/sec, into ZooKeeper. By default a permanent znode tree is created as needed
at {{/hbase/rest/status}} and Stargate instances create ephemeral children of this with names
in the format {{<host>:<port>}}. The ephemeral znodes contain JSON serialized
information about the instance, e.g.
>     {{{"connector":{"host":"restserver.example.com","port":"8080"},"statistics":{"requests":"13"}}}}
> The function of Stargate itself is not affected, except for one significant change: now
if the ZooKeeper service is lost, the Stargate instances will abort along with the rest of
HBase. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message