hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranav Khaitan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3043) 'hbase-daemon.sh stop regionserver' should kill compactions that are in progress
Date Sun, 03 Oct 2010 10:17:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917308#action_12917308
] 

Pranav Khaitan commented on HBASE-3043:
---------------------------------------

Patch looks good!

One possibility is to maintain the variable 'WriteState writestate' as private and add a set
method.

Surprising that the following lock was never being unlocked before.
   void interruptIfNecessary() {
     if (lock.tryLock()) {
-      this.interrupt();
+      try {
+        this.interrupt();
+      } finally {
+        lock.unlock();
+      }
     }
   }


> 'hbase-daemon.sh stop regionserver' should kill compactions that are in progress
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-3043
>                 URL: https://issues.apache.org/jira/browse/HBASE-3043
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.89.20100621, 0.90.0
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>             Fix For: 0.89.20100924, 0.90.0
>
>         Attachments: HBASE-3043_0.89.patch, HBASE-3043_0.90.patch
>
>
> During rolling restarts, we'll occasionally get into a situation with our 100-node cluster
where a RS stop takes 5-10 minutes.  The problem is that the RS is undergoing a compaction
and won't stop until it is complete.  In a stop situation, it would be preferable to preempt
the compaction, delete the newly-created compaction file, and try again once the cluster is
restarted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message