hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3082) For ICV gets, first look in MemStore before reading StoreFiles
Date Thu, 21 Oct 2010 04:42:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923317#action_12923317
] 

HBase Review Board commented on HBASE-3082:
-------------------------------------------

Message from: "Ryan Rawson" <ryanobjc@gmail.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1053/#review1596
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/regionserver/InternalScan.java
<http://review.cloudera.org/r/1053/#comment5396>

    Why not put these into the base class?  Why create an entirely new class just to hold
these?



src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
<http://review.cloudera.org/r/1053/#comment5397>

    Would this code be cleaner if we didnt have to use instanceof?


- Ryan





> For ICV gets, first look in MemStore before reading StoreFiles
> --------------------------------------------------------------
>
>                 Key: HBASE-3082
>                 URL: https://issues.apache.org/jira/browse/HBASE-3082
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Jonathan Gray
>            Assignee: Prakash Khemani
>
> For incrementColumnValue operations, it is possible to check MemStore for the column
being incremented without sacrificing correctness.  If the column is not found in MemStore,
we would then have to do a normal Get that opens/checks all StoreFiles for the given Store.
> In practice, this makes increment operations significantly faster for recently/frequently
incremented columns.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message