hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3163) If we timeout PENDING_CLOSE and send another closeRegion RPC, need to handle NSRE from RS (comes as a RemoteException)
Date Fri, 29 Oct 2010 22:55:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926490#action_12926490
] 

HBase Review Board commented on HBASE-3163:
-------------------------------------------

Message from: "Jonathan Gray" <jgray@apache.org>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1130/
-----------------------------------------------------------

Review request for hbase and stack.


Summary
-------

Unwraps RemoteExceptions and we don't abort if it's an NSRE.

This handling is rather different from the handling of opens (we abort in some cases here),
so we might consider making them the same and no longer aborting here.  I'm fine with leaving
it for a while longer as we do all this testing.


This addresses bug HBASE-3163.
    http://issues.apache.org/jira/browse/HBASE-3163


Diffs
-----

  trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1028936 

Diff: http://review.cloudera.org/r/1130/diff


Testing
-------


Thanks,

Jonathan




> If we timeout PENDING_CLOSE and send another closeRegion RPC, need to handle NSRE from
RS (comes as a RemoteException)
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3163
>                 URL: https://issues.apache.org/jira/browse/HBASE-3163
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.90.0
>            Reporter: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.90.0
>
>
> When we send a closeRegion RPC to an RS, we are catching NSRE but when the RS is the
one throwing the NSRE, then it comes back as a RemoteException (then an NSRE) and we aren't
unwrapping it properly.
> We need to catch this and then deal with it appropriately.
> Still tracking how this happened in the first place.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message