hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-3181) Review, document, and fix up Regions-in-Transition timeout logic
Date Sun, 31 Oct 2010 23:21:24 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926791#action_12926791

HBase Review Board commented on HBASE-3181:

Message from: "Jonathan Gray" <jgray@apache.org>

This is an automatically generated e-mail. To reply, visit:

Review request for hbase and stack.


Does cleanup of RIT timeouts according to document in progress.  Still finishing document
but I'd like to get this patch tested before finalizing it.

Also found some strange stuff in server shutdown handling that could have easily led to some
double assignment issues that stack was seeing.

This addresses bug HBASE-3181.


  trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 1029466 
  trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1029466 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029466 
  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 1029466

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java 1029466

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1029466

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 1029466

  trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1029466 

Diff: http://review.cloudera.org/r/1143/diff


Working on tests now.  This definitely changes some behavior that is tested in the new TestMasterFailover
so need to figure if the test should change or whether we need to handle things like CLOSING.
 Maybe let it timeout a few times?



> Review, document, and fix up Regions-in-Transition timeout logic
> ----------------------------------------------------------------
>                 Key: HBASE-3181
>                 URL: https://issues.apache.org/jira/browse/HBASE-3181
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, regionserver, zookeeper
>    Affects Versions: 0.90.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Blocker
>             Fix For: 0.90.0
> In some of the testing Stack and I have been doing, we've uncovered some issues with
concurrent RS failure and when the Master is under heavy load.  It's led to situations where
we handle ZK events far after they actually occur and have uncovered some issues in our timeout
> This jira is about reviewing the timeout semantics, especially around ZK usage, and ensuring
that we handle things appropriately.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message