Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <31667881.108551284093212885.JavaMail.jira@thor>
Date: Fri, 10 Sep 2010 00:33:32 -0400 (EDT)
From: "HBase Review Board (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Subject: [jira] Commented: (HBASE-2977) Refactor HMaster command line tool
 into a new class
In-Reply-To: <13848820.108051284089252901.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907879#action_12907879 ] 

HBase Review Board commented on HBASE-2977:
-------------------------------------------

Message from: stack@duboce.net

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/811/#review1145
-----------------------------------------------------------

Ship it!


+1

One minor item below -- take it or leave it


src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
<http://review.cloudera.org/r/811/#comment3947>

    Suggest MasterCommandLine rather than H* (I hate the 'H' in front of everything)


- stack


> Refactor HMaster command line tool into a new class
> ---------------------------------------------------
>
>                 Key: HBASE-2977
>                 URL: https://issues.apache.org/jira/browse/HBASE-2977
>             Project: HBase
>          Issue Type: Task
>          Components: master
>    Affects Versions: 0.90.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>
> The whole main() thing inside of HMaster is a bit messy. I'd like to refactor it to a new class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.