hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2980) Refactor HRegionServer command line parsing
Date Mon, 13 Sep 2010 17:28:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908871#action_12908871
] 

HBase Review Board commented on HBASE-2980:
-------------------------------------------

Message from: "Todd Lipcon" <todd@cloudera.com>


bq.  On 2010-09-10 08:42:41, stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java, line 48
bq.  > <http://review.cloudera.org/r/812/diff/1/?file=11389#file11389line48>
bq.  >
bq.  >     Daemon is a good name but maybe use the not so good 'ServerCommandLine' so it
aligns w/ the new Server Interface we extracted from Master and RS
bq.  >     
bq.  >     Or we could change the 'Server' Interface name to Daemon?

Will change to ServerCommandLine like you suggested. Want to re-review the change or shall
I just commit when fixed?


- Todd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1151
-----------------------------------------------------------





> Refactor HRegionServer command line parsing
> -------------------------------------------
>
>                 Key: HBASE-2980
>                 URL: https://issues.apache.org/jira/browse/HBASE-2980
>             Project: HBase
>          Issue Type: Task
>          Components: regionserver
>    Affects Versions: 0.90.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.90.0
>
>
> Similar to HBASE-2977, refactor the command line parsing logic out of the HRegionServer
class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message