hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HBASE-2961) Close zookeeper when done with it (HCM, Master, and RS)
Date Fri, 10 Sep 2010 00:04:32 GMT

     [ https://issues.apache.org/jira/browse/HBASE-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-2961:
-------------------------

    Attachment: 2961-v3.txt

{code}
Make it so zk shutdown is clean.  Did it by making each server have
its own Configuration and hence its own HConnection instance, then
in each server (and client) added HCM.deleteConnection on way out. This
runs clean up of the HConnection.. Added to HConnection#close the shutdown
of zk.

Did other refactor while in here; removed crazy ServerConnection and
ServerConnectionManager stuff substituting new RootRegionTracker in its
place.

Tried to fix outstanding tests.  One still failing.

M src/test/java/org/apache/hadoop/hbase/TestMultiParallel.java
  Up retries for now to make tests pass.  Needs rewrite.
M src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
  Make a new Configuration so the setting of less tries has an effect
  and we don't retry for ever and fail the test.
M src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditor.java
  Minor formatting.
M src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
  Reuse predefined variable.
M src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
  Renamed of TableServers to HCI
M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
  Removed ServerConnection.  Use HConnection.
  Use RootRegionTracker to keep tabs on root location.
  Add logging of zk sessionid to help w/ debug
M src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
  Minor formatting.
M src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogReader.java
  Need to preserve EOF if thats what we got.
M src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
  Minor reformatting.
M src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
M src/main/java/org/apache/hadoop/hbase/master/HMaster.java
M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
  ServerConnection is gone.  Use HConnection instead.
M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
  Renamed TableServers as HConnectionImplementation
  Use RootRegionTracker for figuring root location. Made it so could get
  rid of some locateRegion code.
  Added clearRegionCache(tableName) override.
M src/main/java/org/apache/hadoop/hbase/client/HConnection.java
  Added clearRegionCache(tableName)
M src/main/java/org/apache/hadoop/hbase/client/ServerConnection.java
M src/main/java/org/apache/hadoop/hbase/client/ServerConnectionManager.java
  Deleted crazy stuff.
M src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
  On delete of table, don't delete connection; connection is more than 
  just a connection to an individual table.
{code}

> Close zookeeper when done with it (HCM, Master, and RS)
> -------------------------------------------------------
>
>                 Key: HBASE-2961
>                 URL: https://issues.apache.org/jira/browse/HBASE-2961
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.0
>
>         Attachments: 2961-v2.txt, 2961-v3.txt, 2961.txt, debug.txt
>
>
> We're not closing down zk properly, mostly in HCM.  Makes for spew in zk logs and it
also causes shutdown to run longer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message