hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2972) remove all inappropriate @Override decorators
Date Wed, 08 Sep 2010 23:09:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907474#action_12907474
] 

Jonathan Gray commented on HBASE-2972:
--------------------------------------

I thought in java6 that @Override could now be used with interfaces.  I find it an extremely
useful annotation and my eclipse generates the @override when it auto-creates a class that
implements an interface.

http://blogs.sun.com/ahe/entry/override_snafu

Is your redhat eclipse doing java5 verification?

> remove all inappropriate @Override decorators
> ---------------------------------------------
>
>                 Key: HBASE-2972
>                 URL: https://issues.apache.org/jira/browse/HBASE-2972
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 0.20.7, 0.90.0
>
>         Attachments: HBASE-2972-0.20.patch, HBASE-2972-trunk.patch
>
>
> Red Hat's version of Eclipse barfs all over the place on HBase code. The problem is technically
inappropriate use of the @Override decorator. See http://download.oracle.com/javase/1.5.0/docs/api/java/lang/Override.html.
Should only be used when a method declaration is intended to override a method declaration
in a superclass, NOT an interface. 
> Attached janitorial patches removes all inappropriate @Override decorators on interface
methods on trunk and 0.20 branch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message