hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HBASE-3028) No basescanner means no GC'ing of split, offlined parent regions
Date Fri, 24 Sep 2010 05:25:32 GMT

     [ https://issues.apache.org/jira/browse/HBASE-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-3028:
-------------------------

    Attachment: 3028-v4.txt

Here is a complete patch:

{code}
M src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
  Test of new basescanner (now called catalogjanitor).  Mocks up
  a 'Server' and a 'MasterServies'.  Tests the check for references
  and gc'ing of let-go of offlined parent regions.
M src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
  (removeRegionFromMeta): Removed.  Users should be going via
  MetaEditor instead.
M src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
  (isSplitParent): Added.
M src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
  Minor formatting
M src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
  New chore that runs every 5 minutes.  It scans .META. and if
  it finds a parent row that is offlined and marked as product of
  a split, it will check daughters to see if they have references.
  If none, the row is removed and its content in FS is cleaned up.
  This is the old 0.20 BaseScanner brought forward into TRUNK
  only now it does this one check only (The fixup of dropped
  splits is done as part of server shutdown handling in TRUNK).
M src/main/java/org/apache/hadoop/hbase/master/HMaster.java
  Added in start and stop of new CatalogJanitor Chore.  Also
  made a stopServiceThreads to match startServiceThreads.  I
  moved into this new method from 'run' the stopping of all threads
  started in startServiceThreads.
M src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
  Refactored fullScan so it now works by taking a Visitor.  Default
  fullScan does as it used to only via a Visitor now.  Adding in
  this facility means I can use the fullScan code when doing the
  catalog janitorial chore.
M src/main/java/org/apache/hadoop/hbase/catalog/MetaEditor.java
  (deleteDaughterReferenceInparent): Added.
M src/main/java/org/apache/hadoop/hbase/util/Threads.java
  Added a setDaemonThreadRunning override that gets the name to use
  from the passed thread.
{code}

> No basescanner means no GC'ing of split, offlined parent regions
> ----------------------------------------------------------------
>
>                 Key: HBASE-3028
>                 URL: https://issues.apache.org/jira/browse/HBASE-3028
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: stack
>             Fix For: 0.90.0
>
>         Attachments: 3028-v2.txt, 3028-v4.txt, 3028.txt
>
>
> I need to add back cleanup of split parents probably as a Chore in master.  Can use new
MetaReader code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message