hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2962) Add missing methods to HTableInterface (and HTable)
Date Sat, 04 Sep 2010 17:55:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906263#action_12906263
] 

Lars Francke commented on HBASE-2962:
-------------------------------------

Another thing: Javadoc automatically copies comments from parent to child methods so we'd
only need those in HTableInterface and could remove them from HTable to avoid duplicate work.
On the other hand this and other issues show how easy it is to forget HTableInterface....

> Add missing methods to HTableInterface (and HTable)
> ---------------------------------------------------
>
>                 Key: HBASE-2962
>                 URL: https://issues.apache.org/jira/browse/HBASE-2962
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>            Reporter: Lars Francke
>             Fix For: 0.90.0
>
>         Attachments: HBASE-2962.1.diff
>
>
> HBASE-1845 added two new methods in HTable (batch). Those need to be in HTableInterface
as well.
> And in HTable we have:
> * put(Put)
> * put(List<Put>)
> * delete(Delete)
> * delete(List<Delete>)
> * get(Get)
> Shouldn't we add a get(List<Get>) as well for consistency?
> Others that are missing:
> * getRegionLocation
> * getScannerCaching / setgetScannerCaching
> * getStartKeys / getEndKeys / getStartEndKeys
> * getRegionsInfo
> * setAutoFlush
> * getWriteBufferSize / setWriteBufferSize
> * getWriteBuffer
> * prewarmRegionCache
> * serializeRegionInfo / deserializeRegionInfo
> For some of those it might not make sense to add them. I'm just listing them all.
> The patch is trivial once we've decided which to add, I'll prepare one for batch &
get.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message