Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 34986 invoked from network); 13 Aug 2010 19:02:41 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Aug 2010 19:02:41 -0000 Received: (qmail 54462 invoked by uid 500); 13 Aug 2010 19:02:41 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 54402 invoked by uid 500); 13 Aug 2010 19:02:41 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 54318 invoked by uid 99); 13 Aug 2010 19:02:40 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Aug 2010 19:02:40 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Aug 2010 19:02:38 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o7DJ2HfF016009 for ; Fri, 13 Aug 2010 19:02:17 GMT Message-ID: <12902101.337201281726137163.JavaMail.jira@thor> Date: Fri, 13 Aug 2010 15:02:17 -0400 (EDT) From: "ryan rawson (JIRA)" To: issues@hbase.apache.org Subject: [jira] Updated: (HBASE-2914) Profiling indicates that ThriftUtilities.rowResultFromHBase is quite inefficient In-Reply-To: <2959274.337161281726136391.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ryan rawson updated HBASE-2914: ------------------------------- Attachment: HBASE-2914.patch this patch is against the branch but it should hopefully apply to trunk w/o much trouble > Profiling indicates that ThriftUtilities.rowResultFromHBase is quite inefficient > -------------------------------------------------------------------------------- > > Key: HBASE-2914 > URL: https://issues.apache.org/jira/browse/HBASE-2914 > Project: HBase > Issue Type: Bug > Affects Versions: 0.20.6, 0.89.20100621 > Reporter: ryan rawson > Assignee: ryan rawson > Fix For: 0.90.0 > > Attachments: HBASE-2914.patch > > > Profiling of ThriftServer here at SU has indicated that the call ThriftUtilities.rowResultFromHBase() is quite inefficient. It first calls Result.getRowResult() which is inefficient and slow. Instead by reimplementing to create the TRowResult (the thrift return type) straight from the KeyValue[] array the performance boost is substantial, reducing time serializing the results. In my profiling the time spent in scannerGetList() went from 1100ms to 108ms on similar test runs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.