hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2695) HMaster cleanup and refactor
Date Mon, 16 Aug 2010 05:13:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898793#action_12898793
] 

stack commented on HBASE-2695:
------------------------------

@Jon For what I've done so far, read commit notes (do an svn log).  There is still loads to
do but I think I'm up to speed now so we can tag-team hack now.  Here's some questions I have:

{code}
+ Q: Can I miss events like data changed znode data events?
+ Q: Why when we start a master do we assign root and meta?  Thats a mistake?
+ Q: We let out IEs and KEs?  What are we doing to do w/ them up in the higher levels of server?
+ ClusterStatusTracker is wrong.  Its znode is root region location rather than clusterStatusZNode
( /hbase/shutdown)?
+ In zkassign, we need to fix how it takes regionname when it really wants encodedregionname
-- errorprone; should just pass regioninfo everytime.
+ I movd to use event handlers to shutdown regions inside regionserver always rather than
handlers when master asks that a region be shutdown but some other code when RS determines
it needs to shutdown.  Made it so for RS ordained shutdown, e.g. it noticed cluster shutdown
or manual shutdown requested, we do not have the closeregionhandler report to zk though its
the close region handler that is running.  Any problem w/ that that you can see?  What if
master sends over a close region on a region close already queued?
{code}

> HMaster cleanup and refactor
> ----------------------------
>
>                 Key: HBASE-2695
>                 URL: https://issues.apache.org/jira/browse/HBASE-2695
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.90.0
>
>         Attachments: HBASE-2695-MasterStartupCleanup-v4.patch, HBASE-2695-part1-masterstatus.patch,
HBASE-2695-part2.1-masterstatus.patch, HBASE-2695-ZK-Master-FINAL-v4.patch
>
>
> Before doing the more significant changes to HMaster, it would benefit greatly from some
cleanup, commenting, and a bit of refactoring.
> One motivation is to nail down the initialization flow and comment each step.  Another
is to add a couple new classes to break up functionality into helpers to reduce HMaster size
(for example, pushing all filesystem operations into their own class).  And lastly to stop
the practice of passing around references to HMaster everywhere and instead pass along only
what is necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message