hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2844) Capping the number of regions
Date Sun, 08 Aug 2010 05:44:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896324#action_12896324
] 

HBase Review Board commented on HBASE-2844:
-------------------------------------------

Message from: "Pranav Khaitan" <pranavkhaitan@facebook.com>


bq.  On 2010-08-04 21:43:56, stack wrote:
bq.  > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServer.java,
line 49
bq.  > <http://review.cloudera.org/r/334/diff/2/?file=2893#file2893line49>
bq.  >
bq.  >     Should we even include this test Pranav?  I don't see where you are proving
that we do not exceed the limit or that the limit works.  Also, where are you making the splits
in this test? 
bq.  >     
bq.  >     I'm fine committing the patch without this test -- the code as is looks fine
to me.

Stack, 

In the test, splits are being made by inserting lot of data and checking
frequently for splits. However, it is a time consuming test. I completely
agree with you that the tests for this are not really necessarily and they
require a lot of testing time. I was under the impression that any change
requires a corresponding test and therefore added it.


- Pranav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/334/#review678
-----------------------------------------------------------





> Capping the number of regions
> -----------------------------
>
>                 Key: HBASE-2844
>                 URL: https://issues.apache.org/jira/browse/HBASE-2844
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Pranav Khaitan
>            Assignee: Pranav Khaitan
>            Priority: Minor
>
> It may sometimes be advantageous to prevent the number of regions from growing very large.
This may happen if the values are large in size even though the number of keyvalues are not
large. If the number of regions becomes too large, then it is difficult to accommodate the
memstore for each region in memory. In such cases, we either have to flush out memstore to
disk or decrease size of each memstore.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message