Return-Path: Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: (qmail 24328 invoked from network); 16 Jul 2010 20:26:14 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 16 Jul 2010 20:26:14 -0000 Received: (qmail 69948 invoked by uid 500); 16 Jul 2010 20:26:14 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 69893 invoked by uid 500); 16 Jul 2010 20:26:14 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 69885 invoked by uid 99); 16 Jul 2010 20:26:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Jul 2010 20:26:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Jul 2010 20:26:11 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o6GKPonD008105 for ; Fri, 16 Jul 2010 20:25:50 GMT Message-ID: <4059575.426201279311950048.JavaMail.jira@thor> Date: Fri, 16 Jul 2010 16:25:50 -0400 (EDT) From: "HBase Review Board (JIRA)" To: issues@hbase.apache.org Subject: [jira] Commented: (HBASE-2553) Revisit IncrementColumnValue implementation in 0.22 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889304#action_12889304 ] HBase Review Board commented on HBASE-2553: ------------------------------------------- Message from: stack@duboce.net ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/325/#review412 ----------------------------------------------------------- Ship it! +1 There are a few minors in the below perhaps worth considering. src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java Why not just use newKv? If there is a kv in front of newKv, then our counters are going to be off? src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java See KeyValue.matchingQualifier() or KeyValue.matchingColumn src/main/java/org/apache/hadoop/hbase/regionserver/Store.java There is a tab here? - stack > Revisit IncrementColumnValue implementation in 0.22 > --------------------------------------------------- > > Key: HBASE-2553 > URL: https://issues.apache.org/jira/browse/HBASE-2553 > Project: HBase > Issue Type: Bug > Reporter: ryan rawson > Assignee: ryan rawson > Fix For: 0.92.0 > > > right now we are using too much of the old get code, we need to review that and constrain how this works but without breaking ICV. > Also we should be resetting the timestamp on every ICV call, and removing the older version. Instead of 'updating' an ICV "in place" we should be adding a new one, removing the old one from memstore (if it is there). This will play well with the atomic approach added in HBASE-2248 since we are only touching 1 KeyValue at a time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.