hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase Review Board (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2863) HBASE-2553 removed an important edge case
Date Thu, 22 Jul 2010 14:12:50 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891176#action_12891176
] 

HBase Review Board commented on HBASE-2863:
-------------------------------------------

Message from: stack@duboce.net

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/354/#review450
-----------------------------------------------------------


At least missing license needs fixing.  There's at least one question in the below too.  Good
stuff.


src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.hbase.org/r/354/#comment1878>

    Nice.



src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.hbase.org/r/354/#comment1879>

    Nice here too



src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.hbase.org/r/354/#comment1880>

    Good stuff.



src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
<http://review.hbase.org/r/354/#comment1881>

    Could this first kv on the row in memstore have a ts in advance of 'now'?  I suppose it
can't -- least it shouldn't be possible, right?
    
    If  thousands of updates a second, could this be a prob?  This logic?



src/main/java/org/apache/hadoop/hbase/util/ManualEnvironmentEdge.java
<http://review.hbase.org/r/354/#comment1882>

    Missing license



src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
<http://review.hbase.org/r/354/#comment1883>

    Nice test


- stack





> HBASE-2553 removed an important edge case 
> ------------------------------------------
>
>                 Key: HBASE-2863
>                 URL: https://issues.apache.org/jira/browse/HBASE-2863
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.90.0
>
>
> in HBASE-2553 an important edge case whereby a KV with the same TS in snapshot was lost,
tests have been failing (but flakly so) indicating it as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message