hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HBASE-1729) Move cache stats out of RS log and into metrics
Date Tue, 27 Jul 2010 19:59:17 GMT

     [ https://issues.apache.org/jira/browse/HBASE-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack resolved HBASE-1729.
--------------------------

    Resolution: Invalid

Cache already tickles metrics and with time, I've gotten accustomed to the blah the lru dumps
the logs.  Resolving as invalid (though I did make below change as part of this issue):

{code}
diff --git a/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java b/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
index 9d157c3..784cb15 100644
--- a/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
+++ b/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
@@ -95,7 +95,7 @@ public class LruBlockCache implements BlockCache, HeapSize {
   static final float DEFAULT_MEMORY_FACTOR = 0.25f;
 
   /** Statistics thread */
-  static final int statThreadPeriod = 60;
+  static final int statThreadPeriod = 60 * 5;
 
   /** Concurrent map (the cache) */
   private final ConcurrentHashMap<String,CachedBlock> map;
{code}

> Move cache stats out of RS log and into metrics
> -----------------------------------------------
>
>                 Key: HBASE-1729
>                 URL: https://issues.apache.org/jira/browse/HBASE-1729
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.0
>
>
> We log this every minute in RS logs:
> {code}
> 2009-07-30 16:24:54,479 DEBUG org.apache.hadoop.hbase.io.hfile.LruBlockCache: Cache Stats:
Sizes: Total=414.8218MB (434972192), Free=252.50949MB (264775392), Max=667.3313MB (699747584),
Counts: Blocks=1106, Access=273562, Hit=271671, Miss=1891, Evictions=0, Evicted=0, Ratios:
Hit Ratio=99.30874705314636%, Miss Ratio=0.691250991076231%, Evicted/Run=NaN
> {code}
> Thats a metric.  Should be over in metrics.  Metrics does some of above but not all.
 Extend it so just as comprehensive.  Then we can see it ganglia, jmx, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message